Skip to content

add KubernetesClient.Aot to support Aot #1498

Merged
k8s-ci-robot merged 21 commits intokubernetes-client:masterfrom
tg123:aotfinal
Jan 29, 2024
Merged

add KubernetesClient.Aot to support Aot #1498
k8s-ci-robot merged 21 commits intokubernetes-client:masterfrom
tg123:aotfinal

Conversation

@tg123
Copy link
Member

@tg123 tg123 commented Jan 13, 2024 •
edited
Loading

#1395

the main project cannot support aot due to dependencies or some dynamic requirements, for example crd json/yaml serialization
the solution now is doing the same as .Classic, to create a separate project, trim aot non friendly features

Known unsupported features

  • Watch
  • LeaderElection (watch related)
  • Customized Patch Object

@brendanburns please also register KubernetesClient.Aot to nuget.org

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 13, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (master@1cae561). Click here to learn what that means.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master    #1498   +/-   ##
=========================================
  Coverage          ?   70.46%           
=========================================
  Files             ?       89           
  Lines             ?     2641           
  Branches          ?      552           
=========================================
  Hits              ?     1861           
  Misses            ?      780           
  Partials          ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tg123 tg123 marked this pull request as ready for review January 14, 2024 12:33
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 14, 2024
@tg123 tg123 mentioned this pull request Jan 14, 2024
Closed
@tg123 tg123 mentioned this pull request Jan 14, 2024
Closed
@guillaume-chervet
Copy link

guillaume-chervet commented Jan 17, 2024

@tg123 I hope you will succeed :)

I'am waiting a lot for this awesome PullRequest :)

@tg123
Copy link
Member Author

tg123 commented Jan 17, 2024

i am also working on making watch for aot
need some big refactor and will try to merge 2 projects together

@brendandburns
Copy link
Contributor

brendandburns commented Jan 22, 2024

I need a .nuget file to add it to nuget.org. Shall I wait until this merges?

@tg123
Copy link
Member Author

tg123 commented Jan 22, 2024

lets merge first and get nuget from github action

@guillaume-chervet
Copy link

guillaume-chervet commented Jan 22, 2024

@tg123 it would be awesome :)

@brendandburns
Copy link
Contributor

brendandburns commented Jan 29, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 29, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, tg123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [brendandburns,tg123]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 00c4c6f into kubernetes-client:master Jan 29, 2024
WeihanLi
WeihanLi reviewed Jan 30, 2024
View reviewed changes
src/KubernetesClient.Aot/KubernetesClient.Aot.csproj
</ItemGroup>

<ItemGroup>
<Reference Include="System.Net.Http" Condition="'$(TargetFramework)' == 'net48'" />
Copy link
Contributor

@WeihanLi WeihanLi Jan 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seemed this can be removed since we target for net8.0 only for this project

Copy link
Member Author

@tg123 tg123 Jan 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, copy paste issue, will fix it

@guillaume-chervet
Copy link

guillaume-chervet commented Jan 30, 2024

Thank you @tg123 will test it today :)

@tg123
Copy link
Member Author

tg123 commented Jan 30, 2024

@guillaume-chervet thank you

@tg123 tg123 deleted the aotfinal branch January 9, 2025 07:00
This was referenced Sep 17, 2025
Open
Closed
Closed
Closed
Closed
@dependabot dependabot bot mentioned this pull request Oct 15, 2025
Merged
@dependabot dependabot bot mentioned this pull request Oct 26, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brendandburns brendandburns Awaiting requested review from brendandburns

1 more reviewer

@WeihanLi WeihanLi WeihanLi left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@brendandburns brendandburns

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tg123 @codecov-commenter @guillaume-chervet @brendandburns @k8s-ci-robot @WeihanLi